[0.2.x]: Fix warning, remove #[deny(warnings)] but keep check on CI #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ryankurte (rust_highfive has picked a reviewer for you, use r? to override) |
|
ryankurte
approved these changes
May 27, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 27, 2020
214: [0.2.x]: Fix warning, remove #[deny(warnings)] but keep check on CI r=ryankurte a=eldruin This fixes #213. Additionally I removed #[deny(warnings)] but added a check for it on CI. I think we should cherry pick #138 to the 0.2.x branch as well and release a 0.2.4 version, since 1.0 will still take a while. I can do that in a separate PR. Co-authored-by: Diego Barrios Romero <[email protected]>
|
Build failed: |
|
CI tests failed on rust nightly due to untagged-option. I have updated the |
|
@ryankurte Could you retry? Travis seems not to have run after I updated the dependency. |
|
bors retry |
|
🔒 Permission denied Existing reviewers: click here to make adamgreig a reviewer |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #213. Additionally I removed #[deny(warnings)] but added a check for it on CI.
I think we should cherry pick #138 to the 0.2.x branch as well and release a 0.2.4 version, since 1.0 will still take a while.
I can do that in a separate PR.